_registration and possibly other configuration storage tables

This is a discussion on _registration and possibly other configuration storage tables within the Feature Requests forums, part of the Help & Support category; Hello, Just look at _registration table. Each registration setting name is in comlumn name of this table, and value - ...


Go Back   68 Classifieds Forums > Help & Support > Feature Requests

 
LinkBack Thread Tools Display Modes
  #1  
Old 09-22-2008, 11:43 AM
Junior Member
 
Join Date: Jun 2008
Posts: 5
Rep Power: 0
Thumbs down _registration and possibly other configuration storage tables

Hello,

Just look at _registration table. Each registration setting name is in comlumn name of this table, and value - in coresponding single line field. And most values are multiple, separated with "|" ...

Storing settings like this is ugly as hell and totally not appropriate for commercial product .

So please, can we have a proper settings table with (name,value) and simple api like isEnabled("cityRequired") or getValue("smtpHost"), setValue("smtHost", $server). Hope you understand the idea. More elegant, simple and clean code. And ONLY ONE TABLE for all global settings (site, registration settings and whatever else, didn't review all settings storage tables).

Realy simple to implement, a bit more complex to migrate everything, but a must do thing.

Reply With Quote
  #2  
Old 09-22-2008, 11:45 AM
68 Classifieds Staff
 
Join Date: Mar 2006
Location: Belmont, NC
Posts: 4,289
Rep Power: 98
Default

Yes this has been thought about but as you say "more complex to migrate everything".

That is the tricky part and the reason it is still the way it is. At the end of the day it is ugly but it works. So it hasn't been a high priority.
__________________
Eric Barnes
68 Classifieds Developer
Please do not send me a private message asking for support. Instead use these open forums or our ticket system.

Customer Area | Issue Tracker | Documentation | 68C Mods | Submit a Ticket | Twitter
Reply With Quote
  #3  
Old 09-22-2008, 12:09 PM
Moderator
 
Join Date: Mar 2006
Posts: 3,630
Rep Power: 89
Default

Quote:
Originally Posted by plaukas View Post

Realy simple to implement, a bit more complex to migrate everything, but a must do thing.
Why is this a "must do"?
__________________
Larry.
(Please note: I am not a 68C employee. I am a customer and volunteer who helps with questions where I can and the forums spam free)

Set your site apart from the competition with one of my modules......
Google Map Module | You Tube Module | Google Calendar Module

68 Classifieds Important Links
Customer Area | Issue Tracker | Knowledge Base | User Manuals
Reply With Quote
  #4  
Old 09-22-2008, 12:36 PM
Junior Member
 
Join Date: Jun 2008
Posts: 5
Rep Power: 0
Default

For ease if further development, simpler and more clear database structure (less redundant tables).

Yes, it works now. But sometimes.. For example, I needed to check if captchas are enabled for user registration.

I have choices:
1. write inline query
2. write function for example captchaEnabled, put it somewhere and use.
3. or, like someone DID, just decide proper captcha validation is just not important, because it's just too much to code:

Quote:
//the form has been submitted so lets validate it and update the info
//is captcha enabled?
if(isset($_POST['captcha']) && $_POST['captcha']=="Y")
{
.......
}
in file userjoin.php

What actualy makes captchas easily bypassable. So now you see where ugly data structures leads?

PS: I hope it gets noticed (I mean captcha check) and will be fixed in next release
Reply With Quote

Bookmarks

Tags
settings

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


All times are GMT -4. The time now is 04:52 AM.


Powered by vBulletin® Version 3.7.3
Copyright ©2000 - 2009, Jelsoft Enterprises Ltd.
Search Engine Friendly URLs by vBSEO 3.2.0

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22