Display ALL active listings under category list

[wabugi]

Hi redking.

That's the point. All listings are only displayed when watching the category.php. As soon as you click on sub categories, no ads from their sub categories are being displayed.

I've read many threads in this forum and always when it comes to this issue anyone says "we can't do it because the server load will be too high".

Well there are other websites which CAN do it. ebay for example displays all listings from all sub categories. Ok ebay is very big and complex. They have masses of servers and nearly unlimited resources. But for a normal user this kind of displaying listings is logic and understandable.

Let's forget the server load for a moment. Is it possible to always display all listings from a category including the listings from it's sub categories (and of course again their sub categories)?

I really would like to be able to do this with my website and I want to see myself how dramatic the increase of the server load is.

Don't understand me wrong. I don't want to force people to work overtime just to get me a solution ^^
But this feature requests has been several times on this forum and maybe a more preciser answer or slution would help solving this issue.

[rdouglas]

Hi wabugi,

Did you find a solution to this?

Originally Posted by wabugi

Hi redking.

That's the point. All listings are only displayed when watching the category.php. As soon as you click on sub categories, no ads from their sub categories are being displayed.

I've read many threads in this forum and always when it comes to this issue anyone says "we can't do it because the server load will be too high".

Well there are other websites which CAN do it. ebay for example displays all listings from all sub categories. Ok ebay is very big and complex. They have masses of servers and nearly unlimited resources. But for a normal user this kind of displaying listings is logic and understandable.

Let's forget the server load for a moment. Is it possible to always display all listings from a category including the listings from it's sub categories (and of course again their sub categories)?

I really would like to be able to do this with my website and I want to see myself how dramatic the increase of the server load is.

Don't understand me wrong. I don't want to force people to work overtime just to get me a solution ^^
But this feature requests has been several times on this forum and maybe a more preciser answer or slution would help solving this issue.

[wabugi]

Hi rdouglas,

no I didn't find a solution yet. My website will go online in maybe 2 weeks from now on (if I have enough time to work on it) and I would really like to have this feature included.

I already startet a feature request but it seems like this feature is not very popular.

[Eric Barnes]

I just looked into this again and I remember now why it is so difficult.

Here is a test I ran.

category.php:
Find: $options['section']=$sec;
Replace with:
$arr_childs = array($sec);
$Categories->get_ids($arr_childs);
$options['cats'] = $arr_childs;

includes/classes/kernel/Listings.php
add:
$where .= ( empty($options['cats']) ) ? '': " AND p.section In (". implode(', ', $options['cats']) .")";
inside the getAllListings method.

[wabugi]

Hi Eric. I'm very happy that you follow this issue.

I did what you said. Now my complete listing database is being displayed in every category ^^

That's where I inserted the code in the listings.php:

        function getAllListings($options, $current_row, $max)
        {
                global $db, $class_tpl, $modules;
                if(defined('IN_ADMIN')) {
                $sSQL = 'SELECT * FROM '.PREFIX.'listings as p';
                }
                else
                {
                   $where .= ( empty($options['cats']) ) ? '': " AND p.section In (". implode(', ', $options['cats']) .")";

In Category.php I still have 2 old changes which you suggested some weeks ago. That was:
To show all listings open category.php and find:
$showlistings='N';

Change to:
$showlistings='Y';

Find:
$options['section']=$sec;

Change to:
if(isset($sec)) {
$options['section']=$sec;
}

Is it possible that these changes are not compatible with the new changes? Or are these changes still needed?

[Eric Barnes]

I knew I would open up a can of worms posting that.
The best bet is to just start doing some debugging on your own and seeing how it all ties together. With the code I posted above it was added to stock files.

[wabugi]

What I've done now:

I updated my installation from v4.13 to 4.14.

In root/category.php:
Find: $showlistings='N';
ChangeTo: $showlistings='Y';

Find: $options['section']=$sec;
ChangeTo: if(isset($sec)) {
$arr_childs = array($sec);
$Categories->get_ids($arr_childs);
$options['cats'] = $arr_childs;
}

And I added the new code to root/includes/classes/kernel/listings.php like this:

function getAllListings($options, $current_row, $max)
{
global $db, $class_tpl, $modules;
$where .= ( empty($options['cats']) ) ? '': " AND p.section In (". implode(', ', $options['cats']) .")";

That`s a combination of the old solution displaying ALL listings in the root category and your new solution for displaing ALL listings of sub categories in their parent categories.

This solution now seems to work! Until now I didn't find any errors.

Thank you again for having another look at this issue. I`m very happy with that solution now ^^

If I find any malfunctions or errors I will post them here.

[rdouglas]

Eric,

This works for me too. Thanks!

PS. make sure you have category > allow ads > YES set in the admin panel

Originally Posted by Eric Barnes

I just looked into this again and I remember now why it is so difficult.

Here is a test I ran.

category.php:
Find: $options['section']=$sec;
Replace with:
$arr_childs = array($sec);
$Categories->get_ids($arr_childs);
$options['cats'] = $arr_childs;

includes/classes/kernel/Listings.php
add:
$where .= ( empty($options['cats']) ) ? '': " AND p.section In (". implode(', ', $options['cats']) .")";
inside the getAllListings method.

[pipelin]

Hi,

I used this code (I had to put category > allow ads > YES set in the admin panel, in every category. I think this code needs some change. it's not right allow ads en every category):


category.php:
Find: $options['section']=$sec;
Replace with:
$arr_childs = array($sec);
$Categories->get_ids($arr_childs);
$options['cats'] = $arr_childs;

includes/classes/kernel/Listings.php
add:
$where .= ( empty($options['cats']) ) ? '': " AND p.section In (". implode(', ', $options['cats']) .")";
inside the getAllListings method.

and it works almost perfect, except when I click the menu option "browse", I got this error:

Notice: Query failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 SQL: SELECT id FROM class_clacategories WHERE parent_id In () in /home/content/r/a/g/ragomez79/html/includes/classes/database/mysql.php on line 143

Notice: Query failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AND p.price BETWEEN 0 AND 99999999999 AND p.expiration > NOW() AND p.display =' at line 1 SQL: SELECT p.id, p.owner, p.title, p.featured, p.section, p.shortDescription, p.description, p.price, p.dateadded, p.expiration, p.display, p.pHighlighted, p.pBold, p.hitcount, p.url, u.username, u.state, u.city, u.country, u.extra, u.extra2, u.extra3 FROM class_clalistings AS p LEFT JOIN class_clausers AS u ON p.owner = u.id WHERE 1=1 AND p.section In () AND p.price BETWEEN 0 AND 99999999999 AND p.expiration > NOW() AND p.display = "Y" GROUP BY p.id, p.owner, p.title, p.featured, p.section, p.description, p.dateadded, p.expiration, u.state, u.city, u.country ORDER BY featured desc in /home/content/r/a/g/ragomez79/html/includes/classes/database/mysql.php on line 143

Notice: Query failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AND p.price BETWEEN 0 AND 99999999999 AND p.expiration > NOW() AND p.display =' at line 1 SQL: SELECT p.id, p.owner, p.title, p.featured, p.section, p.shortDescription, p.description, p.price, p.dateadded, p.expiration, p.display, p.pHighlighted, p.pBold, p.hitcount, p.url, u.username, u.state, u.city, u.country, u.extra, u.extra2, u.extra3 FROM class_clalistings AS p LEFT JOIN class_clausers AS u ON p.owner = u.id WHERE 1=1 AND p.section In () AND p.price BETWEEN 0 AND 99999999999 AND p.expiration > NOW() AND p.display = "Y" GROUP BY p.id, p.owner, p.title, p.featured, p.section, p.description, p.dateadded, p.expiration, u.state, u.city, u.country ORDER BY featured desc LIMIT 0, 10 in /home/content/r/a/g/ragomez79/html/includes/classes/database/mysql.php on line 143

Can someone help me, please?

[Fatih67]

IS there any solution ?

I tried all code from forum but I have the same problem with other people.

also I dont want to accept ads main categories

this is very very important for me