Mod: Favorites Image Fix

[crystal]

There are two issuses I found with the favorites heart image when viewing a listing. This fixes both.

- When a user adds a listing to their favorites, the text changes from "Add to favorites" to "Delete from favorites" but the heart image does not change. But wait... it is supposed to! The script comes stock with an image to replace the heart ("favorites_delete.gif") but the code does not use it.

- When a user is not logged in, there is no image at all. All other text has an icon, so the "login to save favorites" text is boring and looks like something is missing.

Here is my fix for both problems at once (using the default template):

1. Open templates/default/css/style.css

Find:

.favorites {
	background: url('../images/favorites.gif') left top no-repeat;
	padding: 0px 0 2px 20px;
	margin-left: 10px;
	height: 16px;
}

Add Under:

.delfavorites {
	background: url('../images/favorites_delete.gif') left top no-repeat;
	padding: 0px 0 2px 20px;
	margin-left: 10px;
	height: 16px;
}

2. Open templates/default/viewlisting/listingextras.tpl
-OR-
Open listingextras2.tpl if you are using the "short description view" setting (viewlisting2.tpl).

Find :

	<span class="favorites"><span id="response">
		{if $smarty.session.uid}
			{if $isFavorite==0}
				<a href="javascript:void(0);" onclick="saveFavorite({$smarty.session.uid}, {$view})">{$smarty.const.LANG_ADD_FAVORITES}</a>
			{else}
				<a href="javascript:void(0);" onclick="removeFavorite({$smarty.session.uid}, {$view})">{$smarty.const.LANG_DELETE_FROM_FAVORITES}</a>
			{/if}
		{else}
			<a href="login.php?goto={$goto}">{$smarty.const.LANG_PLEASE_LOGIN_FAVORITES}</a>
		{/if}

Replace with:

<span id="response">
		{if $smarty.session.uid}
			{if $isFavorite==0}
				<span class="favorites"><a href="javascript:void(0);" onclick="saveFavorite({$smarty.session.uid}, {$view})">{$smarty.const.LANG_ADD_FAVORITES}</a></span>
			{else}
				<span class="delfavorites"><a href="javascript:void(0);" onclick="removeFavorite({$smarty.session.uid}, {$view})">{$smarty.const.LANG_DELETE_FROM_FAVORITES}</a></span>
                                        {/if}
                            {else}
			<span class="favorites"><a href="login.php?goto={$goto}">{$smarty.const.LANG_PLEASE_LOGIN_FAVORITES}</a></span>
		{/if}

3. Make sure the "favorites_delete.gif" image is uploaded in your template /images folder. If you are using the default or purple template it is already there.

NOTE: I changed my LANG_PLEASE_LOGIN_FAVORITES text to "Login to save favorites" before I did this fix. You may need to make that change in the languages/english.php file if the default text is too long to have an icon text to it.

Hope this fix helps! It is minor and aesthetic but it makes a difference. Eric, feel free to add it in.

[seymourjames]

Couldnt' make this work unless I did this. An {/if} before the {else} is required.

<span class="delfavorites"><a href="javascript:void(0);" onclick="removeFavorite({$smarty.session.uid}, {$view})">{$smarty.const.LANG_DELETE_FROM_FAVORITE S}</a></span>
{/if}
{else}
Wanted to add that it is a nice little detail to add this. Thanks.

[Eric Barnes]

This was added to v4.0.3 and thanks for posting the fix.

[seymourjames]

Not problem. That now answers my question in your post of 4.03 what are the changes - I was trying to spot the changes in files that affect me where I have made changes - for me always in template (I may wish to use them) and in english.php (not sure you marked it as you usually do in the latter).

[Eric Barnes]

The only change in English was the text change crystal added. Nothing major.

[crystal]

Originally Posted by seymourjames

Couldnt' make this work unless I did this. An {/if} before the {else} is required.

<span class="delfavorites"><a href="javascript:void(0);" onclick="removeFavorite({$smarty.session.uid}, {$view})">{$smarty.const.LANG_DELETE_FROM_FAVORITE S}</a></span>
{/if}
{else}
Wanted to add that it is a nice little detail to add this. Thanks.

Thanks, I have added that in to the code above. Mine requires the {/if} statement to work also. After I did this to my template, I applied the fix to the default template so I could post it (didn't test). Looks like that slipped through! Thanks for the correction.