Expired ads showing as "Active" on userbrowselistings

civ · (#1)

I just reset a password for one of my advertisers and logged into her account to test it. I noticed that her expired listing was showing up as active on userbrowselistings, and there was no renew link! I checked it in the admincp and it shows there as "Expired".

Can anyone else confirm this? This is a serious hindrance to profitability if left unsolved, so I need to fix this ASAP.

3.1.5 Developer

civ · (#2)

Anyone mind logging in as a customer and checking this on 3.1.5?

SkGold · (#3)

I checked it. Here what I did:
My renewal setting in admin is 5 days.
I was manually changing expiration date for one of my ad.
The renewal link is there but only appear 5 days before and 5 days after expiration date. I guess it is Okay.
More than 5 days after expiration date the renewal link disappears.
What is not Okay that the ad status is showing Active after renewal link disappears. I think it should be changed to Expired. Maybe it a bug?

civ · (#4)

Yep, that's what I'm seeing as well. Definitely a bug - I'll file a report.

Thanks for checking Sergey!

civ · (#5)

Sorry for digging this old thread up, but we are missing lots of renewals due to this bug. I just got another email from a customer today trying unsuccessfully to renew his listing, so I was reminded to come back here and check onthe status.

Here is the bugtracker entry I entered last month - anyone found a solution to this problem yet?
http://www.68classifieds.com/issues/...md=view&id=122

Here is a screenshot from a customer's userbrowselistings.php (note the expiration date but the 'Active' status, as well as the lack of a 'Renew' link):

**juven14** · (#6)

I think this is a bug, what I think is happening is the smarty comparsion isn't taking place due to the date not being a time stamp.

Open userbrowselistings.tpl.php:

find:

Code:

{if $entry.expiration > $smarty.now}
             {$smarty.const.LANG_EXPIRED}
         {elseif $entry.display == "Y"}
             {$smarty.const.LANG_YES}
         {else}
             {$smarty.const.LANG_NO}
         {/if}

Try replacing with this:

Code:

{if $entry.expiration|date_format > $smarty.now|date_format}
             {$smarty.const.LANG_EXPIRED}
         {elseif $entry.display == "Y"}
             {$smarty.const.LANG_YES}
         {else}
             {$smarty.const.LANG_NO}
         {/if}

civ · (#7)

Hi John, that didn't make any difference.

**juven14** · (#8)

Replace:

Code:

{if $entry.expiration > $smarty.now}

With:

Code:

{if $entry.expiration|date_format:"%Y/%m/%d" < $smarty.now|date_format:"%Y/%m/%d"}

civ · (#9)

Thanks John! That corrected the 'Active' column - it now displays 'Expired' as expected.

There is still no Renew link however.

**juven14** · (#10)

That is strange, I am getting the renewal link, though I tested it with an expired ad. I'll look at it again in the am.